Vote account parsing does not consider optional value + new account data

[ochaloup]

I troubled with an issue with the fromAccountData method

solana-web3.js/packages/library-legacy/src/vote-account.ts

Line 180 in 24d71d6

static fromAccountData(

I want to deserialize data from AccountInfo.

as the deserialization was failing I needed to start checking the Solana code and I found a new version of the account is different from an "old" one.
Difference at Solana code at

• https://github.com/solana-labs/solana/blob/v1.17.15/sdk/program/src/vote/state/vote_state_0_23_5.rs#L7
• https://github.com/solana-labs/solana/blob/v1.17.15/sdk/program/src/vote/state/vote_state_1_14_11.rs#L8
• https://github.com/solana-labs/solana/blob/0c2d69a016af32ac684651e7c91d9bb69fa8df8c/sdk/program/src/vote/state/vote_state_versions.rs#L10

Adding new account buffer was not enough as the current processing has an issue that does not consider the rootSlot as being optional (https://github.com/solana-labs/solana/blob/v1.17.15/sdk/program/src/vote/state/vote_state_1_14_11.rs#L22) and it requires it being defined all the time (https://github.com/solana-labs/solana-web3.js/blob/v1.88.0/packages/library-legacy/src/vote-account.ts#L90-L91). That's a wrong wrong deserialization processing.

I don't know what's the exactly ways around this code (it's under legacy) and I haven't tried to put into any tests.
First I would like to know if it's desirable to have the code here. Then I would like to get some feedback on the code and (if it's considered fine) then if you can share what's needed to finish the PR to be merge-able. Thanks.

[steveluscher]

Thanks for pushing, here. This situation is not great and I appreciate you taking a stab!

[steveluscher]

It should also be possible to decode options with tagged unions, right? The discriminator in this case is the 0 or the 1.

[ochaloup]

I'm sorry, I haven't got this. Can you please point me to some example?

[steveluscher]

Yeah! It's like this case:

https://github.com/coral-xyz/anchor/blob/211982affc37883ef6b04578757d2815f63a7fef/ts/packages/anchor/src/program/token-account-layout.ts#L132-L138

…but where 0 means its None and where 1 means it's Some.

[buffalojoec]

This could also be helpful:

https://github.com/solana-labs/solana-program-library/blob/260f80928f796fc78c81efa4dc2a7732665e5a59/token/js/src/serialization.ts#L5-L39

https://github.com/solana-labs/solana-program-library/blob/260f80928f796fc78c81efa4dc2a7732665e5a59/token/js/src/extensions/transferFee/instructions.ts#L39-L46

[ochaloup]

@steveluscher awesome, thanks for your feedback and points 👍 I haven't got to this earlier but finally I have an update.

I changed to use the version parsing as you suggested. While I fight with the buffer layout a bit so not sure if it's how you like this to be. Let me know in comment if/what should be changed. Thanks again.

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.