Create coded exceptions for invariant violations #2242
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
force-pushed
the
03-04-Create_coded_exceptions_for_invariant_violations
branch
from
f2a99cc
to
80f64a6
Compare
|
Add link to issue tracker |
steveluscher
changed the base branch from
master
to
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
steveluscher
force-pushed
the
03-04-Create_coded_exceptions_for_invariant_violations
branch
from
80f64a6
to
097c92d
Compare
steveluscher
force-pushed
the
03-04-Let_the_new_coded_exceptions_from_codecs-core_bubble_up_as-is_through_solana/options_
branch
from
ea29eaa
to
9a1834c
Compare
| throw new SolanaError(SOLANA_ERROR__INVARIANT_VIOLATION_SWITCH_MUST_BE_EXHAUSTIVE, { | ||
| unexpectedValue: commitment satisfies never, | ||
| }); |
There was a problem hiding this comment.
This one smells a little bit. I guess the only way this gets thrown is if someone isn't using TypeScript (or ignores it) and sends a string that isn't a valid Commitment. Shouldn't the error say that, then? ie. SOLANA_ERROR__INVALID_COMMITMENT_VALUE?
There was a problem hiding this comment.
Yeah, I was trying to make something that was generally usable for exhaustive switches. The error location will tell the developer where the unhandled value was thrown, which I figured was enough paired with the actual unexpected value.
There was a problem hiding this comment.
There was a problem hiding this comment.
I do actually like that we have utility errors for these sort of invariants.
steveluscher
force-pushed
the
03-04-Create_coded_exceptions_for_invariant_violations
branch
from
097c92d
to
1041fb6
Compare
Merge activity
|
steveluscher
deleted the
03-04-Create_coded_exceptions_for_invariant_violations
branch
|
🎉 This PR is included in version 1.91.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Summary
Invariant violations are a kind of error that should never get hit ever, and if they do your program is broken.
In one sense we don't want error codes for them because they're not intended to be caught in downstream programs. On the other hand I've tried to come up with a reason not to give them codes and I can't.
Making them a
@solana/errorgives us compression and error decoding for free.Addresses #2118.