Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add getter for logs to sendTransactionError #2771

Merged
merged 3 commits into from
Jun 5, 2024
Merged

chore: Add getter for logs to sendTransactionError #2771

merged 3 commits into from
Jun 5, 2024

Conversation

Woody4618
Copy link
Contributor

  • Add a getter for logs with the old types to be a non breaking change

@Woody4618
Add getter for logs to sendTransactionError
2e7a686 
- Add a getter for logs with the old types to be a non breaking change
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 535677d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Jun 4, 2024
@mergify mergify bot requested a review from a team June 4, 2024 22:08
steveluscher
steveluscher requested changes Jun 4, 2024
View reviewed changes
packages/library-legacy/src/errors.ts Outdated
};
}

/* @deprecated Use `await getLogs()` instead */
get logs() {
return this.transactionLogs as string[] | undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be true, right? It could be a Promise? I think you have to just return undefined if 'then' in this.transactionLogs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I added that check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully now it will not be a breaking change anymore.

@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Jun 5, 2024
@steveluscher steveluscher merged commit 327dc9d into solana-labs:master Jun 5, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.92.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher requested changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Woody4618 @steveluscher