Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana 1.10.{3,5,6} build issue #24114

Closed
chenrui333 opened this issue Apr 4, 2022 · 1 comment
Closed

solana 1.10.{3,5,6} build issue #24114

chenrui333 opened this issue Apr 4, 2022 · 1 comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@chenrui333
Copy link

chenrui333 commented Apr 4, 2022

👋 trying to build the latest release, but run into some build issue. The error log is as below:

build error
  error: cannot find derive macro `Deserialize` in this scope
    --> net-shaper/src/main.rs:12:10
     |
  12 | #[derive(Deserialize, Serialize, Debug)]
     |          ^^^^^^^^^^^
     |
  error: cannot find derive macro `Serialize` in this scope
    --> net-shaper/src/main.rs:12:23
     |
  12 | #[derive(Deserialize, Serialize, Debug)]
     |                       ^^^^^^^^^
     |
  error[E0277]: the trait bound `NetworkTopology: Deserialize<'_>` is not satisfied
      --> net-shaper/src/main.rs:375:9
       |
  375  |         serde_json::from_str(&config).expect("Failed to parse log as JSON");
       |         ^^^^^^^^^^^^^^^^^^^^ the trait `Deserialize<'_>` is not implemented for `NetworkTopology`
       |
  error[E0277]: the trait bound `NetworkTopology: Serialize` is not satisfied
      --> net-shaper/src/main.rs:482:42
       |
  482  |     let topology = serde_json::to_string(&config).expect("Failed to write as JSON");
       |                    --------------------- ^^^^^^^ the trait `Serialize` is not implemented for `NetworkTopology`
       |                    |
       |                    required by a bound introduced by this call
       |                 

full build log, https://github.com/Homebrew/homebrew-core/runs/5824825896
relates to

@l0k18
Copy link

l0k18 commented Apr 9, 2022

I just want to weigh in that this error is exactly caused by running out of memory.

The cargo build command on a vanilla fresh clone of the repository needs at least 25gb of memory, and after necking down the parallelisation with a directive in .cargo/config.toml to 3, I was able to get it to pass through these things sooner, but then it got very stuck and chewed up 16gb on 3 parallel jobs, and one of them was a benchmark.

What is a benchmark doing in the middle of the build plan? This benchmark also hammered my spinning disk equipped (due to accident of a motherboard without an M.2 socket) machine even harder. I am pretty sure this benchmark has been delaying standard builds on most users machines by at least 15 if not 30 minutes from scratch.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

2 participants