Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger cleanup service's configuration needs to be tied to something #7552

Closed
sagar-solana opened this issue Dec 18, 2019 · 2 comments
Closed
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Milestone

Comments

@sagar-solana
Copy link
Contributor

sagar-solana commented Dec 18, 2019

Problem

#7515 introduced a fixed number of slots that ledger cleanup service will keep around in the ledger (MAX_LEDGER_SLOTS).

This number isn't tied to slot time or snapshot interval and it might need to.
For example:

  • If the snapshot interval is longer than the MAX_LEDGER_SLOTS then we cannot guarantee being able to restart
  • If the slot time or epoch length is reduced, the number of slots we need to keep around might increase

Proposed Solution

If possible, justify the chosen value of MAX_LEDGER_SLOTS using a combination of snapshot_interval (cap or fix snapshot interval?) and Slot time.

Tag: @pgarg66

@mvines mvines added this to the Rincon v0.24.0 milestone Dec 21, 2019
@mvines mvines modified the milestones: Rincon v0.24.0, The Future! Feb 11, 2020
@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 13, 2021
@stale
Copy link

stale bot commented Mar 20, 2021

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Mar 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

2 participants