Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust nightly to 2020-07-12 #11015

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Bump rust nightly to 2020-07-12 #11015

merged 2 commits into from
Jul 13, 2020

Conversation

mvines
Copy link
Member

@mvines mvines commented Jul 12, 2020

No description provided.

@mvines mvines added the CI Pull Request is ready to enter CI label Jul 12, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jul 12, 2020
@mvines mvines changed the title Bump rust nightly to 2020-07-11 Bump rust nightly to 2020-07-12 Jul 12, 2020
@mvines
Copy link
Member Author

mvines commented Jul 12, 2020

Hmm, coverage build fails with errors like:

 undefined reference to `sol_log_'

Aaron1011 added a commit to Aaron1011/solana-program-library that referenced this pull request Jul 13, 2020
@Aaron1011
Copy link
Contributor

The undefined reference to 'sol_log_' error is due to the fact that pre-1.2.10 versions of solana-sdk require sol_log_ to be provided by solana-sdk-bpf-test. Since solana-sdk doesn't actually declare a dependency on solana-sdk-bpf-test, rustc is not guaranteed to pass the rlib archives to the linker in the proper order (solana-sdk before solana-sdk-bpf-test).

The coverage build passes -C link-dead-code, which causes the sol_log wrapper (which references sol_log_ to be codegenned), even if is never called. If the rlibs happen to get passed to the linker in the wrong order, a link error will occur.

CriesofCarrots pushed a commit to solana-labs/solana-program-library that referenced this pull request Jul 13, 2020
@Aaron1011
Copy link
Contributor

@mvines You should be able to bump spl-memo now

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #11015 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #11015     +/-   ##
=========================================
- Coverage    82.2%    82.1%   -0.1%     
=========================================
  Files         318      318             
  Lines       73249    73275     +26     
=========================================
- Hits        60218    60201     -17     
- Misses      13031    13074     +43     

@mergify mergify bot merged commit d3784ca into solana-labs:master Jul 13, 2020
@mvines mvines deleted the nite branch July 14, 2020 00:14
nickblt pushed a commit to rally-dfs/anchor-token-swap that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants