Remove move_loader and librapay #11184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also remove mention of Libra Move from the doc's implemented-proposals? |
|
Also need to remove |
|
@jackcmay, looks like CI is about to pass. This look good to you? |
Codecov Report
@@ Coverage Diff @@
## master #11184 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 319 318 -1
Lines 74007 74002 -5
=========================================
- Hits 60810 60801 -9
- Misses 13197 13201 +4 |
|
post-merge reviews welcome |
|
I'm excited about the 30min this cut off stable CI |
Merged
mvines
pushed a commit
to mvines/solana
that referenced
this pull request
Aug 1, 2020
* Remove move_loader and librapay * Remove Embedding Move from implemented proposals * Remove Move variant from CI * Remove move_loader ID
mvines
pushed a commit
that referenced
this pull request
Aug 2, 2020
* Remove move_loader and librapay * Remove Embedding Move from implemented proposals * Remove Move variant from CI * Remove move_loader ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Move build introduces dependency conflicts.
Summary of Changes
Remove it. If needed, it can be resurrected in the SPL repo.