-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retransmits shreds recovered from erasure codes (backport #19233) #20249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working towards sending shreds (instead of packets) to retransmit stage so that shreds recovered from erasure codes are as well retransmitted. Following commit will add these metrics back to window-service, earlier in the pipeline. (cherry picked from commit bf437b0) # Conflicts: # core/src/retransmit_stage.rs
Adding back these metrics from the earlier commit which removed them from retransmit stage. (cherry picked from commit 8198a7e)
(cherry picked from commit 6e41333) # Conflicts: # core/src/retransmit_stage.rs # core/src/tvu.rs
Working towards channelling through shreds recovered from erasure codes to retransmit stage. (cherry picked from commit 3efccbf) # Conflicts: # core/src/retransmit_stage.rs
instead of opaque (u32, u32) which are then converted to CompletedDataSetInfo at the call-site. (cherry picked from commit 3c71670) # Conflicts: # ledger/src/blockstore.rs
Shreds recovered from erasure codes have not been received from turbine and have not been retransmitted to other nodes downstream. This results in more repairs across the cluster which is slower. This commit channels through recovered shreds to retransmit stage in order to further broadcast the shreds to downstream nodes in the tree. (cherry picked from commit 7a8807b) # Conflicts: # core/src/retransmit_stage.rs # core/src/window_service.rs
automerge label removed due to a CI failure |
automerge label removed due to a CI failure |
4e95081
to
7e1f9c2
Compare
automerge label removed due to a CI failure |
7e1f9c2
to
bd42581
Compare
automerge label removed due to a CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19233 done by Mergify.
Cherry-pick of bf437b0 has failed:
Cherry-pick of 6e41333 has failed:
Cherry-pick of 3efccbf has failed:
Cherry-pick of 3c71670 has failed:
Cherry-pick of 7a8807b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/