fix serialize/deserialize in transaction.ts with stable sort #23024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xx400
changed the title
0xx400
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
see #21722
Sorting pubkey alphabetically could lead to mismatch with offline sign process.
When one signer sign transaction with rust (e.g. with solana cli tool) and another with web3. So, need to make order the same in both case.
Summary of Changes
make sort stable to determine result. JS have unstable sort.
Target behaviour is here:
solana/sdk/program/src/message/legacy.rs
Line 87 in 7ba57e7
Rust have stable sort by default.
Fixes #
#21722