Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-build-sbf, cargo-test-sbf: add --arch option #23465

Merged
merged 1 commit into from
Jul 13, 2022
Merged

cargo-build-sbf, cargo-test-sbf: add --arch option #23465

merged 1 commit into from
Jul 13, 2022

Conversation

alessandrod
Copy link
Contributor

Problem

As we evolve SBF, there needs to be a way to select which version to build for.

Summary of Changes

Add --arch option that can be used to select SBF version. Currently sbf and sbfv2 are supported.

See anza-xyz/llvm-project#26

@dmakarov dmakarov self-requested a review April 16, 2022 01:19
@stale
Copy link

stale bot commented Apr 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 25, 2022
@alessandrod alessandrod removed the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 25, 2022
@stale
Copy link

stale bot commented May 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 2, 2022
@alessandrod alessandrod removed the stale [bot only] Added to stale content; results in auto-close after a week. label May 6, 2022
alessandrod added a commit to anza-xyz/cargo that referenced this pull request Jun 3, 2022
@alessandrod
[SOL] build-std: pull in our compiler-builtins
8d8bc1a 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
@alessandrod alessandrod changed the title cargo-build-bpf: add --arch option cargo-build-sbf: add --arch option Jun 4, 2022
@alessandrod alessandrod changed the title cargo-build-sbf: add --arch option cargo-build-sbf, cargo-test-sbf: add --arch option Jun 4, 2022
@alessandrod alessandrod marked this pull request as ready for review June 4, 2022 14:22
@alessandrod
Copy link
Contributor Author

This is now ready, just blocked on a new bpf-tools release.

dmakarov
dmakarov previously approved these changes Jun 4, 2022
View reviewed changes
@stale
Copy link

stale bot commented Jun 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 12, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Jul 10, 2022
@dmakarov dmakarov reopened this Jul 10, 2022
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Jul 10, 2022
@mergify mergify bot dismissed dmakarov’s stale review July 11, 2022 18:04

Pull request has been modified.

@dmakarov dmakarov self-assigned this Jul 11, 2022
@dmakarov dmakarov force-pushed the cargo-build-bpf-arch branch 3 times, most recently from cf96803 to 63999ea Compare July 13, 2022 04:00
@alessandrod @dmakarov
cargo-build-sbf, cargo-test-sbf: add --arch option
ffaec6e 
--arch allows selecting the target SBF version. See
anza-xyz/llvm-project#26.
@dmakarov dmakarov merged commit ab6802b into solana-labs:master Jul 13, 2022
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Aug 1, 2022
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
6177f0d 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Dec 8, 2022
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
70606cb 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
@dmakarov dmakarov mentioned this pull request Dec 8, 2022
Merged
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Dec 8, 2022
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
702b5c4 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Dec 9, 2022
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
31d418d 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Dec 9, 2022
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
4c67a92 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Mar 17, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
bce7c2f 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Mar 17, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
6189996 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
@dmakarov dmakarov mentioned this pull request Mar 17, 2023
Merged
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Mar 17, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
3abdf7c 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Mar 17, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
5964fe4 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Oct 19, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
42d9289 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Oct 19, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
7f13760 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
@dmakarov dmakarov mentioned this pull request Oct 19, 2023
Merged
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Oct 19, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
c1ba823 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
dmakarov pushed a commit to dmakarov/cargo that referenced this pull request Oct 19, 2023
@alessandrod @dmakarov
[SOL] build-std: pull in our compiler-builtins
378708c 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
LucasSte pushed a commit to LucasSte/cargo that referenced this pull request Feb 5, 2024
@alessandrod @LucasSte
[SOL] build-std: pull in our compiler-builtins
092bed3 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
LucasSte pushed a commit to anza-xyz/cargo that referenced this pull request Feb 16, 2024
@alessandrod @LucasSte
[SOL] build-std: pull in our compiler-builtins
d908575 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
LucasSte pushed a commit to LucasSte/cargo that referenced this pull request Jul 22, 2024
@alessandrod @LucasSte
[SOL] build-std: pull in our compiler-builtins
e44d7e2 
When -Z build-std is used, patch compiler-builtins so that our own fork is
downloaded.

Needed for solana-labs/solana#23465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmakarov dmakarov dmakarov left review comments

Assignees

@dmakarov dmakarov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessandrod @dmakarov