New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leader qos part 2 - add stage to find packet's sender stake #23690
Conversation
let mut send_batches_time = Measure::start("send_batches_time"); | ||
if let Err(e) = sender.send(batches) { | ||
info!("Sender error: {:?}", e); | ||
} | ||
send_batches_time.stop(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: One thing we've started doing is using Measure::this()
solana/core/src/banking_stage.rs
Lines 589 to 593 in 46dfbc9
let (bank_start, poh_recorder_lock_time) = Measure::this( | |
|_| poh_recorder.lock().unwrap().bank_start(), | |
(), | |
"poh_recorder_lock", | |
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find using Measure::this
on simple function with one or no param is cleaner than if function takes multiple params. Not huge fan of adding another indentation tho; nor the mixed use of Measure::this
and "Measure::start` in same code block.
46dfbc9
to
f999ad2
Compare
Codecov Report
@@ Coverage Diff @@
## master #23690 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 581 582 +1
Lines 158312 158437 +125
=========================================
+ Hits 129518 129534 +16
- Misses 28794 28903 +109 |
@carllin do you think can give this PR a green light, or there are rooms to improve? |
Problem
Packet Sender's stake can be helpful information for Leader's prioritization algo.
Summary of Changes
find_packet_sender_stake_stage
, insert it betweenstreamer
andsigverify_stage
.packet.meta.sender_stake
field.Fixes #