Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List cmake as a package to install in build instructions #24199

Merged
merged 1 commit into from Apr 8, 2022

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Apr 8, 2022

Problem

#24147 bumped prost dependency version; the new version requires cmake. Without it, I got the following error building from source

  running: "cmake" "/home/.../.cargo/registry/src/github.com-1ecc6299db9ec823/prost-build-0.10.0/third-party/protobuf/cmake" 
"-DCMAKE_INSTALL_PREFIX=/home/steven_solana_com/solana/target/release/build/prost-build-6551c412a1f344fc/out" 
"-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" 
"-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" 
"-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc"
"-DCMAKE_BUILD_TYPE=Debug"

  --- stderr
  thread 'main' panicked at '
  failed to execute command: No such file or directory (os error 2)
  is `cmake` not installed?

@steviez steviez changed the title Add cmake as a necessary package for building from source List cmake as a package to install in build instructions Apr 8, 2022
@steviez steviez removed v1.9 labels Apr 8, 2022
@steviez steviez merged commit c090418 into solana-labs:master Apr 8, 2022
@steviez steviez deleted the cmake branch April 8, 2022 17:45
@steviez
Copy link
Contributor Author

steviez commented Apr 8, 2022

I was clicking without thinking on backports - we definitely don't need them as this is docs only

@CriesofCarrots
Copy link
Contributor

Thanks for doing this!
Also, fyi I discovered that older cmakes (including the default version for ubuntu 18, cmake v3.10) hits a different error: https://buildkite.com/solana-labs/solana/builds/69769#abc1b1e6-14f9-40b2-858e-592175d33b04
I'll keep an ear out and we can document a msv if it seems to be a issue for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants