Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: Add --jobs parameter in build/test bpf #24359

Merged
merged 1 commit into from Apr 15, 2022

Conversation

joncinque
Copy link
Contributor

Problem

It's impossible to set the number of jobs to build-bpf and test-bpf, since --jobs figures as a pre--- parameter for cargo build and cargo test. The extra parsing to pass the post -- parameters also doesn't pass --jobs correctly, and we're having build failures on cargo test-bpf for the SPL governance program due to memory consumption.

Summary of Changes

Add a --jobs flag to both build-bpf and test-bpf. The parsing looks a bit wonky since it validates it as a number, then stores it as a string. This is done to make it easier to pass into cargo.

@joncinque joncinque requested a review from t-nelson April 14, 2022 22:32
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! that'll do it. nice find!

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #24359 (b085f61) into master (2456a7b) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24359   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         582      582           
  Lines      162385   162385           
=======================================
+ Hits       133406   133414    +8     
+ Misses      28979    28971    -8     

@joncinque joncinque merged commit d54ec40 into solana-labs:master Apr 15, 2022
@joncinque joncinque deleted the tbpf-jobs branch April 15, 2022 11:49
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants