returns Error when Shred::sanitize fails #24653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
shred-sanitize-error
branch
from
99b4b0e
to
154c2a4
Compare
Including the error in the output allows to debug when Shred::sanitize fails.
behzadnouri
force-pushed
the
shred-sanitize-error
branch
from
154c2a4
to
e5ac757
Compare
carllin
approved these changes
Apr 25, 2022
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Apr 26, 2022
solana-labs#24653 introduced an off-by-one error in data-shred index sanitize.
behzadnouri
added a commit
that referenced
this pull request
Apr 26, 2022
#24653 introduced an off-by-one error in data-shred index sanitize.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 27, 2022
Including the error in the output allows to debug when Shred::sanitize fails.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 27, 2022
solana-labs#24653 introduced an off-by-one error in data-shred index sanitize.
whistlinwilly
pushed a commit
to jito-foundation/jito-solana
that referenced
this pull request
May 16, 2022
solana-labs/solana#24653 introduced an off-by-one error in data-shred index sanitize.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Including the error in the output allows to debug when Shred::sanitize fails.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
solana-labs#24653 introduced an off-by-one error in data-shred index sanitize.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Including the error in the output allows to debug when Shred::sanitize fails.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
solana-labs#24653 introduced an off-by-one error in data-shred index sanitize.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Including the error in the output allows to debug when Shred::sanitize fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Including the error in the output allows to debug when Shred::sanitize
fails.
Summary of Changes
return Error when Shred::sanitize fails