(de-)serializes shred headers through a Cursor #24876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current serialize/de-serialize code for shreds manually tracks offsets into the payload; This can instead be done with std::io::Cursor. https://github.com/solana-labs/solana/blob/e812430e2/ledger/src/shred.rs#L232-L258
steviez
reviewed
May 2, 2022
| // Tests may have an empty parity_shard. | ||
| if !parity_shard.is_empty() { | ||
| payload[SIZE_OF_CODING_SHRED_HEADERS..].copy_from_slice(parity_shard); | ||
| let offset = cursor.position() as usize; | ||
| debug_assert_eq!(offset, SIZE_OF_CODING_SHRED_HEADERS); |
There was a problem hiding this comment.
Same as above - think this could be in a unit test
There was a problem hiding this comment.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Current serialize/de-serialize code for shreds manually tracks offsets into the payload; This can instead be done with std::io::Cursor. https://github.com/solana-labs/solana/blob/e812430e2/ledger/src/shred.rs#L232-L258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current serialize/de-serialize code for shreds manually tracks offsets
into the payload; This can instead be done with std::io::Cursor.
https://github.com/solana-labs/solana/blob/e812430e2/ledger/src/shred.rs#L232-L258
Summary of Changes