handle start_http failure in rpc_service #25400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiseda
force-pushed
the
rpc_service-error-fix
branch
from
6fc8fa3
to
83568f9
Compare
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 19, 2022
This reverts commit e263be2.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 21, 2022
This reverts commit e263be2.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 21, 2022
…#25400)"" This reverts commit 7d54b1a45c8d91633fb1f4f365df8dab4fcd27c3.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 21, 2022
This reverts commit e263be2.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 21, 2022
This reverts commit e263be2.
|
For cross reference, this is causing segfaults in rocks-db: #25941 (comment) |
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 22, 2022
This reverts commit e263be2.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jun 22, 2022
…#25400)"" This reverts commit 46ffacd1b7dbf8a2d0f8664101f3889d20c19459.
jbiseda
added a commit
that referenced
this pull request
Jun 22, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
JsonRpcService::new: ifstart_httpfailsclose_handle_senderwill be dropped without sending a value to the channel. Subsequentclose_handle_receiver.recv().unwrap()will fail on the closed channel.Summary of Changes
Send error value over the channel to gracefully handle the failure.
Fixes #