add state while scanning #25418
Merged
add state while scanning #25418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
may45_3_2
branch
4 times, most recently
from
510bbc6
to
3d692fd
Compare
jeffwashington
force-pushed
the
may45_3_2
branch
6 times, most recently
from
a2b5f02
to
b0e5339
Compare
HaoranYi
previously approved these changes
May 24, 2022
| self.mismatch_found.fetch_add(1, Ordering::Relaxed); | ||
| } | ||
| } | ||
| if self.accum.is_empty() { |
There was a problem hiding this comment.
could use init_accum instead.
brooksprumo
previously approved these changes
May 24, 2022
Comment on lines
+1675
to
+1677
| if self.accum.is_empty() { | ||
| self.accum.append(&mut vec![Vec::new(); self.range]); | ||
| } |
There was a problem hiding this comment.
Could this call self.init_accum(self.range) instead?
mergify
bot
dismissed stale reviews from brooksprumo and HaoranYi
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #25418 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 621 621
Lines 170297 170393 +96
=========================================
+ Hits 139917 139946 +29
- Misses 30380 30447 +67 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Aiming towards efficiency and simplicity wrt scanning billions of accounts in multiple passes.
Having a struct can reduce the code that runs per append vec and more importantly per account.
We can also add filtering later, reducing the work to skip accounts that don't match the current pass.
Summary of Changes
Fixes #