fans out gossip pull-requests to many randomly selected peers #25460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
gossip-pull-many
branch
3 times, most recently
from
b6bcd48
to
8bd27a2
Compare
Each time a node generates gossip pull-requests, it sends out all the requests to a single randomly selected peer: https://github.com/solana-labs/solana/blob/fd7ad31ee/gossip/src/crds_gossip_pull.rs#L253-L266 This causes a burst of pull-requests at a single node at once. In order to make gossip in-bound traffic less bursty, this commit fans out gossip pull-requests to several randomly selected peers.
behzadnouri
force-pushed
the
gossip-pull-many
branch
from
8bd27a2
to
7915206
Compare
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
May 26, 2022
test_pull_from_entrypoint_if_not_present relies on a deterministic ordering for the entries when generating gossip pull requests. solana-labs#25460 changed an intermediate type for gossip pull-requests from Vec to HashMap, and so the entries are no longer deterministically ordered. This causes the test to be flaky. The commit updates the test so that it no longer relies on the ordering.
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2022
test_pull_from_entrypoint_if_not_present relies on a deterministic ordering for the entries when generating gossip pull requests. #25460 changed an intermediate type for gossip pull-requests from Vec to HashMap, and so the entries are no longer deterministically ordered. This causes the test to be flaky. The commit updates the test so that it no longer relies on the ordering.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…-labs#25460) Each time a node generates gossip pull-requests, it sends out all the requests to a single randomly selected peer: https://github.com/solana-labs/solana/blob/fd7ad31ee/gossip/src/crds_gossip_pull.rs#L253-L266 This causes a burst of pull-requests at a single node at once. In order to make gossip in-bound traffic less bursty, this commit fans out gossip pull-requests to several randomly selected peers. This should reduce spikes in inbound gossip traffic without changing the average load which may help reduce number of times outbound data budget is exhausted when responding to gossip pull-requests at the receiving node, and reduce number of pull-requests dropped.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
test_pull_from_entrypoint_if_not_present relies on a deterministic ordering for the entries when generating gossip pull requests. solana-labs#25460 changed an intermediate type for gossip pull-requests from Vec to HashMap, and so the entries are no longer deterministically ordered. This causes the test to be flaky. The commit updates the test so that it no longer relies on the ordering.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…-labs#25460) Each time a node generates gossip pull-requests, it sends out all the requests to a single randomly selected peer: https://github.com/solana-labs/solana/blob/fd7ad31ee/gossip/src/crds_gossip_pull.rs#L253-L266 This causes a burst of pull-requests at a single node at once. In order to make gossip in-bound traffic less bursty, this commit fans out gossip pull-requests to several randomly selected peers. This should reduce spikes in inbound gossip traffic without changing the average load which may help reduce number of times outbound data budget is exhausted when responding to gossip pull-requests at the receiving node, and reduce number of pull-requests dropped.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
test_pull_from_entrypoint_if_not_present relies on a deterministic ordering for the entries when generating gossip pull requests. solana-labs#25460 changed an intermediate type for gossip pull-requests from Vec to HashMap, and so the entries are no longer deterministically ordered. This causes the test to be flaky. The commit updates the test so that it no longer relies on the ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context:
https://discord.com/channels/428295358100013066/977244255212937306/977321454716735568
Each time a node generates gossip pull-requests, it sends out all the
requests to a single randomly selected peer:
https://github.com/solana-labs/solana/blob/fd7ad31ee/gossip/src/crds_gossip_pull.rs#L253-L266
This causes a burst of pull-requests at a single node at once. In order
to make gossip in-bound traffic less bursty, this commit fans out gossip
pull-requests to several randomly selected peers.
This should reduce spikes in inbound gossip traffic without changing the
average load which may help reduce number of times outbound data budget is
exhausted when responding to gossip pull-requests at the receiving node, and
reduce number of pull-requests dropped.
Summary of Changes
The commit fans out gossip pull-requests to several randomly selected peers.