Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws5 #261

Merged
merged 2 commits into from
May 27, 2018
Merged

Aws5 #261

merged 2 commits into from
May 27, 2018

Conversation

aeyakovenko
Copy link
Member

No description provided.

@garious
Copy link
Contributor

garious commented May 25, 2018

Rebase please

src/ecdsa.rs Outdated
batches
.iter()
.map(|p| p.read().unwrap().packets.len())
.fold(0, |x, y| x + y)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does iter implement sum()?

poll both endpoints in client

logs

logs

logs

names

verify plan not sig

log

set udp buffer to max

drop output

more verbose about window requests

log the leader

load leader identity

readme for single node demo

update

asserts

update

replay all

rsync

dynamic file read in testnode

fix

cleanup

readme

sum

fix scripts

cleanup

cleanup

readme
@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #261 into master will decrease coverage by 0.06%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage    81.6%   81.53%   -0.07%     
==========================================
  Files          31       31              
  Lines        3104     3109       +5     
==========================================
+ Hits         2533     2535       +2     
- Misses        571      574       +3
Impacted Files Coverage Δ
src/sigverify.rs 92.42% <ø> (+1.37%) ⬆️
src/streamer.rs 65.28% <0%> (-0.37%) ⬇️
src/crdt.rs 45.43% <30.76%> (-0.3%) ⬇️
src/entry_writer.rs 88.57% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e35f54...f9853c5. Read the comment docs.

@aeyakovenko aeyakovenko mentioned this pull request May 26, 2018
9 tasks
@garious garious merged commit 2dbf9a6 into solana-labs:master May 27, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
yhchiang-sol added a commit to yhchiang-sol/solana that referenced this pull request Mar 18, 2024
#### Problem
TieredWritableFile currently uses File instead of BufWriter.
This will introduce more syscall when doing file writes.

#### Summary of Changes
This PR makes TieredWritableFile uses BufWriter to allow the
write-call to be more optimized to reduce the number of syscalls.

#### Test Plan
Existing tiered-storage test.
Will run experiments to verify its performance improvement.

#### Dependency
anza-xyz#260
willhickey pushed a commit that referenced this pull request Mar 20, 2024
#### Problem
TieredWritableFile currently uses File instead of BufWriter.
This will introduce more syscall when doing file writes.

#### Summary of Changes
This PR makes TieredWritableFile uses BufWriter to allow the
write-call to be more optimized to reduce the number of syscalls.

#### Test Plan
Existing tiered-storage test.
Will run experiments to verify its performance improvement.

#### Dependency
anza-xyz#260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants