-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gossip Loop metrics #26195
Add Gossip Loop metrics #26195
Changes from 14 commits
f065c4a
b6dc3f0
416bfc0
80e4868
501a27d
8f938c8
7017142
48cf3b1
a0f61f9
8ad9b1e
2cb636a
748231d
d56526a
ed2498b
4c10184
bb4ab5d
19ea6d2
24b3043
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,6 +113,10 @@ pub struct GossipStats { | |
pub(crate) gossip_pull_request_verify_fail: Counter, | ||
pub(crate) gossip_pull_response_verify_fail: Counter, | ||
pub(crate) gossip_push_msg_verify_fail: Counter, | ||
pub(crate) gossip_transmit_loop_time: Counter, | ||
pub(crate) gossip_transmit_loop_itrs_since_last_report: Counter, | ||
pub(crate) gossip_listen_loop_time: Counter, | ||
pub(crate) gossip_listen_loop_itrs_since_last_report: Counter, | ||
pub(crate) handle_batch_ping_messages_time: Counter, | ||
pub(crate) handle_batch_pong_messages_time: Counter, | ||
pub(crate) handle_batch_prune_messages_time: Counter, | ||
|
@@ -138,6 +142,7 @@ pub struct GossipStats { | |
pub(crate) packets_sent_pull_responses_count: Counter, | ||
pub(crate) packets_sent_push_messages_count: Counter, | ||
pub(crate) process_gossip_packets_time: Counter, | ||
pub(crate) process_gossip_packets_itrs_since_last_report: Counter, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you please keep the fields in this struct alphabetically sorted ? |
||
pub(crate) process_prune: Counter, | ||
pub(crate) process_pull_requests: Counter, | ||
pub(crate) process_pull_response: Counter, | ||
|
@@ -237,6 +242,11 @@ pub(crate) fn submit_gossip_stats( | |
stats.process_gossip_packets_time.clear(), | ||
i64 | ||
), | ||
( | ||
"process_gossip_packets_itrs_since_last_report", | ||
stats.process_gossip_packets_itrs_since_last_report.clear(), | ||
i64 | ||
), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for easier queries, can you please report this in the same table as the other ones? |
||
( | ||
"verify_gossip_packets_time", | ||
stats.verify_gossip_packets_time.clear(), | ||
|
@@ -385,6 +395,26 @@ pub(crate) fn submit_gossip_stats( | |
stats.gossip_pull_request_dropped_requests.clear(), | ||
i64 | ||
), | ||
( | ||
"gossip_transmit_loop_time", | ||
stats.gossip_transmit_loop_time.clear(), | ||
i64 | ||
), | ||
( | ||
"gossip_transmit_loop_itrs_since_last_report", | ||
stats.gossip_transmit_loop_itrs_since_last_report.clear(), | ||
i64 | ||
), | ||
( | ||
"gossip_listen_loop_time", | ||
stats.gossip_listen_loop_time.clear(), | ||
i64 | ||
), | ||
( | ||
"gossip_listen_loop_itrs_since_last_report", | ||
stats.gossip_listen_loop_itrs_since_last_report.clear(), | ||
i64 | ||
), | ||
); | ||
datapoint_info!( | ||
"cluster_info_stats4", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
itrs
->iterations
we usually spell out all words without abbreviations