Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3: restructure files into more directories #27080

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Aug 11, 2022

Summary of Changes

  • Added the transaction and message directories that will hold new code that will be added soon to support versioned transactions.
  • Added the programs and program-tests directories to make it easier to see which programs are supported by this library
  • Renamed util directory to utils

Fixes #

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #27080 (441c4cc) into master (1165a7f) will decrease coverage by 4.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #27080       +/-   ##
===========================================
- Coverage    81.9%    77.5%     -4.4%     
===========================================
  Files         631       46      -585     
  Lines      174252     2469   -171783     
  Branches        0      352      +352     
===========================================
- Hits       142728     1915   -140813     
+ Misses      31524      424    -31100     
- Partials        0      130      +130     

Copy link
Member Author

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveluscher any high level concerns or comments here?

@steveluscher
Copy link
Contributor

More module boundaries the better!

@steveluscher
Copy link
Contributor

Thanks for totally screwing my future rebase of #25839 tho. 😘

@jstarry
Copy link
Member Author

jstarry commented Aug 12, 2022

Thanks for totally screwing my future rebase of #25839 tho. 😘

Oh dang, I forgot to follow up on that. Let's definitely get yours in first. This restructure isn't that pressing

@jstarry jstarry merged commit 8e30dbb into solana-labs:master Aug 12, 2022
@jstarry
Copy link
Member Author

jstarry commented Aug 12, 2022

Sorry @steveluscher, I'd like to get this in first. Feel free to squash the commits in your nonce pr to avoid resolving merge conflicts for each one

@jstarry jstarry deleted the web3/refactor-files branch August 12, 2022 16:12
@steveluscher
Copy link
Contributor

Oh, by all means. No problem. Rebases are afraid of me, not the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants