make feature 28541 a no-op #28553
Merged
make feature 28541 a no-op #28553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
brooksprumo
added
the
feature-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#28543 was submitted to 1.14 to allow us to fix a bug introduced in testnet.
1.14 with #28543 is not compatible with mnb.
Once that feature is activated on testnet, we can merge this pr and re-cut a new 1.14.
This pr keeps the feature, but causes it to do nothing.
This is required such that once this pr is merged, 1.14 will once again be compatible with mnb.
When 1.14 is the minimum supported version, we will activate the no-op feature on mnb and devnet for consistency.
https://discord.com/channels/428295358100013066/910937142182682656/1033137858493562911
Summary of Changes
remove the special, temporary testnet code by reverting #28543, then effectively backport #28542 so that we end up with a no-op feature in 1.14 and master, once testnet has been 'adjusted' by the activation of the feature with #28543
Feature Gate Issue: #28541