Refactor to remove requested_cu from cost_trarcker #29015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
previously approved these changes
Dec 1, 2022
| .unwrap(); | ||
|
|
||
| // set limit ratio so each batch can only have one test transaction, | ||
| // eg ratio = floor(MAX_WRITABLE_ACCOUNT_UNITS- / tx_cost.sum()) |
There was a problem hiding this comment.
either fix the comment (trailling -) or just remove it. I don't think it adds much since the equation is simply the coded line below.
There was a problem hiding this comment.
good point, removed the line
| let requested_cu = | ||
| block_cost_limits::MAX_WRITABLE_ACCOUNT_UNITS.saturating_div(limit_ratio as u64); | ||
| // setup two transactions, one has high priority that writes to hot account, the | ||
| // other write to non-content account with no priority |
… use cost_model forr consistency
tao-stones
force-pushed
the
refactor-remove-requested-cu-from-cost-tracker
branch
from
eed7de4
to
6be50b6
Compare
tao-stones
added
the
automerge
mergify
bot
dismissed
apfitzge’s stale review
Pull request has been modified.
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
tao-stones
added
the
automerge
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* refactor cost tracker by removing requested_cu from it, call sites to use cost_model forr consistency * review fix
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* refactor cost tracker by removing requested_cu from it, call sites to use cost_model forr consistency * review fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Forwarder uses requested_cu to track how many CUs are forwarded. Now cost_model has been updated to use requested_cu (#28281), forwarder should use cost_model for consistency.
Summary of Changes
Fixes #