Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add non vote tps #29293

Closed
wants to merge 2 commits into from
Closed

Conversation

0xksure
Copy link

@0xksure 0xksure commented Dec 16, 2022

Problem

Currently the explorer is not separating non-vote tps and vote tps. This has lead to confusion around how many non-vote tps Solana actually handles. Please see the discussion on twitter for a more detailed discussions
https://mobile.twitter.com/0xMert_/status/1600967856090337281

Summary of Changes

The proposed change is to add a field below the tps count which would show non-vote tps. The non-vote tps is calculated by

  1. taking the 10 last blocks
  2. calculating the number of tx per block that has a compute budget different from 0
  3. grouping by blocktime
  4. removing the first and last blocktime
  5. calculate number of txs over the remaining blocktimes
  6. dividing the sum by number of blocktimes (blocktime in seconds)
  7. then start calculating an running average of non-vote tps

Fixes #

@github-actions github-actions bot added the explorer Related to the Solana Explorer webapp label Dec 16, 2022
@mergify mergify bot added the community Community contribution label Dec 16, 2022
@mergify mergify bot requested a review from a team December 16, 2022 10:36
@mvines
Copy link
Member

mvines commented Dec 19, 2022

@ngundotra was looking at this as well recently. The approach of using getBlock will be much to hard on the RPC servers, we need something like #29159 to land first

@0xksure
Copy link
Author

0xksure commented Dec 21, 2022

@ngundotra was looking at this as well recently. The approach of using getBlock will be much to hard on the RPC servers, we need something like #29159 to land first

Close PR due to PerformanceSamples being updated to contain nonVoteTps

@0xksure 0xksure closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution explorer Related to the Solana Explorer webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants