Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc warnings #29537

Merged
merged 1 commit into from Jan 7, 2023
Merged

Fix doc warnings #29537

merged 1 commit into from Jan 7, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Jan 5, 2023

Problem

cargo doc generates warnings

Summary of Changes

Turn a code block into a not-rust code block. Remove a link to LedgerCleanupService, which can't be reached from the solana-ledger crate because it is in solana-core.

@mergify mergify bot added the community Community contribution label Jan 5, 2023
@mergify mergify bot requested a review from a team January 5, 2023 18:05
@mvines mvines added the CI Pull Request is ready to enter CI label Jan 7, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jan 7, 2023
mvines
mvines approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Jan 7, 2023
@mergify mergify bot merged commit 43a0745 into solana-labs:master Jan 7, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
@brson @gnapoli23
Fix doc warnings (solana-labs#29537)
40f93ef
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
@brson @gnapoli23
Fix doc warnings (solana-labs#29537)
d8da3a7
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
@brson @gnapoli23
Fix doc warnings (solana-labs#29537)
96062d2
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
@brson @gnapoli23
Fix doc warnings (solana-labs#29537)
f07b86a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvines mvines mvines approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brson @mvines @solana-grimes