Remove redundant check during loading upgradeable program for writing

[pgarg66]

Problem

The accounts.rs code currently checks if the message includes upgradeable loader key, if an upgradeable program is being loaded for writing. The check looks necessary and harmless at quick glance. But its unnecessary, as the transaction will fail due to other checks in the execution. The check is making it harder to refactor the code for the runtime V2/Cache replacement (#29803).

Summary of Changes

• Remove the check under a feature gate.
• Update the unit tests.
• Add feature gate.

Feature Gate Issue #30559

[CriesofCarrots]

But its unnecessary, as the transaction will fail due to other checks in the execution.

Can you please link to these checks?

[pgarg66]

But its unnecessary, as the transaction will fail due to other checks in the execution.

Can you please link to these checks?

@Lichtso could you please point to the code?

[Lichtso]

When an account has the is_executable flag set, it essentially becomes immutable, regardless of what is_writable says:

• set_owner
• set_lamports
• set_executable
• set_data

[codecov]

Codecov Report

Merging #30561 (bd360fa) into master (aaac046) will increase coverage by 0.0%.
The diff coverage is 97.2%.

@@           Coverage Diff           @@
##           master   #30561   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         727      727           
  Lines      205250   205282   +32     
=======================================
+ Hits       167378   167428   +50     
+ Misses      37872    37854   -18     

[CriesofCarrots]

Thanks for the program-cache context we discussed directly. This now looks okay to me

[pgarg66]

Activating on testnet in epoch 530.