Retain usage counter on program upgrade #31142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Apr 11, 2023
Lichtso
approved these changes
Apr 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #31142 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 728 728
Lines 206100 206152 +52
=========================================
+ Hits 168098 168121 +23
- Misses 38002 38031 +29 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 14, 2023
* Retain usage counter on program upgrade * cleanup as per feedback * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The usage count for the program resets when the program is upgraded. This could lead to unnecessary eviction of frequently used program on their upgrade.
Summary of Changes
Copy over the usage count to the upgraded program.
Fixes #