Do not evict tombstones #31311
Merged
Do not evict tombstones #31311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31311 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 733 733
Lines 207054 207055 +1
=======================================
+ Hits 168894 168904 +10
+ Misses 38160 38151 -9 |
Lichtso
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Evicting tombstones can cause incorrect view of the cache. If the tombstone and updated program entry both get evicted, the cache can potentially return old program to the caller.
Summary of Changes
Do not evict tombstones. Also updated the tests.
Fixes #