Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Renames loader-v3 to loader-v4. #31570

Merged
merged 1 commit into from
May 11, 2023

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented May 10, 2023

Problem

The first three loaders started counting their version names at 1 not at 0.

Summary of Changes

Renames loader-v3 to loader-v4.

@Lichtso
Copy link
Contributor Author

Lichtso commented May 10, 2023

@ripatel-jump FYI.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #31570 (9de0f81) into master (8e9b064) will decrease coverage by 0.1%.
The diff coverage is 97.5%.

@@            Coverage Diff            @@
##           master   #31570     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         734      734             
  Lines      205278   205278             
=========================================
- Hits       166926   166919      -7     
- Misses      38352    38359      +7     

@Lichtso Lichtso requested a review from pgarg66 May 10, 2023 14:55
@Lichtso Lichtso merged commit bbd8be6 into solana-labs:master May 11, 2023
15 checks passed
@Lichtso Lichtso deleted the rename/loader_v4 branch May 11, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants