[zk-keygen] create cli utility and add new command
#31641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31641 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 736 736
Lines 207493 207493
=========================================
- Hits 168755 168746 -9
- Misses 38738 38747 +9 |
zk-keygen/src/main.rs
Outdated
| .disable_version_flag(true) | ||
| .arg( | ||
| Arg::new("key_type") | ||
| .short('t') |
There was a problem hiding this comment.
| .short('t') |
(throughout)
we typically avoid declaring shortopts in the solana tools. a few have sneaked in over the years and they are all ambiguous in some contexts today
There was a problem hiding this comment.
Okay! I removed the shortopt for key_type. The rest of the shortops were taken from solana-keygen so we should probably leave it for consistency?
There was a problem hiding this comment.
i'd prefer to not propagate any of the short args from solana-keygen
There was a problem hiding this comment.
Okay, all shortopts are now removed!
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
Will do first thing tomorrow! |
zk-keygen/src/main.rs
Outdated
| Arg::new("outfile") | ||
| .long("outfile") | ||
| .value_name("FILEPATH") | ||
| .takes_value(true) | ||
| .help("Path to generated file"), |
There was a problem hiding this comment.
(Sorry in advance for this 😞) I know @t-nelson had you take out all the short definitions, but I think we should preserve this one. I use solana-keygen -o all the time; I think it's intuitive and much easier than typing the long flag.
There was a problem hiding this comment.
Yeah, I also use the -o flag often and it is used quite a bit in the solana docs cli examples as well. I added it back in for now, but @t-nelson please let me know if you feel strongly against this. I'd be happy to go either way.
There was a problem hiding this comment.
my opinion here isn't strong. would be nice to add it back hidden, but i don't see any obvious what to only hide the short opt with clap v3
There was a problem hiding this comment.
Hm, yeah I don't quite see an easy way to hide just the short opt. Since this is not marked for publication just yet, let's keep the short opt for now. There will be a chance to discuss it again before publication.
Co-authored-by: Tyera <teulberg@gmail.com>
There was a problem hiding this comment.
Lgtm! Quick, merge it before @t-nelson notices the outfile thing ;)
Problem
There is currently no cli utility to create encryption keys (ElGamal and authenticated encryption) used for token-2022 and more generally zero-knowledge proofs.
Summary of Changes
Create a
zk-keygencli tool to generate encryption keys and add thenewcommand that randomly generates encryption keys analogously tokeygen.Other commands like
recover(recover key/keypair from passphrase) andpubkey(print out pubkey from an ElGamal keypair) will be added in a follow-up PR.The
solana-zk-keygenis marked not for publication for now.Fixes #