Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Disables Downstream Project actions #32983

Merged

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Aug 24, 2023

Problem

In #32982, which in turn is necessary to upgrade Rust (see #32961), we change a public interface here in the monorepo, which is used by the SPL repo. Both repositories form a cycle of CI dependency.

Summary of Changes

Removes the GitHub action files "downstream-project-spl.yml" and "downstream-project-spl-nightly.yml".
This should be reverted once v1.17 is branched off.

@Lichtso Lichtso requested a review from t-nelson August 24, 2023 21:00
@t-nelson
Copy link
Contributor

i think we can be a little less intrusive with jobs.<job>.if

...
  jobs:
    job_name:
      if: false
      ...
    ...

@Lichtso
Copy link
Contributor Author

Lichtso commented Aug 24, 2023

The if clause is already used by some jobs, and I don't want to change them. This as it is, is a far more obvious revert IMO.

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lichtso Lichtso merged commit 68456fa into solana-labs:master Aug 24, 2023
14 checks passed
@Lichtso Lichtso deleted the ci/disable_downstream_projects_actions branch August 24, 2023 21:50
@joncinque
Copy link
Contributor

Is it possible to only remove the CLI jobs and general test one? This looks like it's only affecting public CLI APIs, correct?

@t-nelson
Copy link
Contributor

Is it possible to only remove the CLI jobs and general test one? This looks like it's only affecting public CLI APIs, correct?

everything that touches RemoteWallet 'cause it's grossly over constrained 🤕

@joncinque
Copy link
Contributor

everything that touches RemoteWallet 'cause it's grossly over constrained 🤕

That means that programs and tests are totally fine, right? Can we be a bit more selective about what we disable? We're working so hard on avoiding breaking changes in the SDK and I don't want us to slip up.

Thankfully, the remote wallet changes won't impact program developers, which is why I'm not advocating for a normal deprecation strategy.

@t-nelson
Copy link
Contributor

which is why I'm not advocating for a normal deprecation strategy

that makes one of us

joncinque added a commit to joncinque/solana that referenced this pull request Aug 24, 2023
joncinque added a commit to joncinque/solana that referenced this pull request Aug 25, 2023
joncinque added a commit that referenced this pull request Aug 25, 2023
* Revert "CI - Disables Downstream Project actions (#32983)"

This reverts commit 68456fa.

* CI: Disable "check" and "test" jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants