Set loader-v4 program deployment slot at actual deployment #33278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33278 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 790 790
Lines 214273 214273
=========================================
- Hits 175661 175643 -18
- Misses 38612 38630 +18 |
Lichtso
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The program deployment fails when using loader-v4.
Summary of Changes
The truncate instruction sets the deployment slot for the program to the current slot when the buffer is being initialized. The deploy instruction checks if
DEPLOYMENT_COOLDOWN_IN_SLOTShave elapsed since the last deployment.DEPLOYMENT_COOLDOWN_IN_SLOTSis set to 750, so the deployment fails (since the CLI sends truncate and deploy instructions in quick succession).Taking a step back, the truncate instruction should not be setting the deployment slot when the buffer is being initialized. It should only be set at the time of program deployment.
Fixes #