Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Enable Program-Runtime-v2 and Loader-v4 #33294

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Sep 18, 2023

Problem

The loader-v4 is currently unreachable outside of unit tests. So, a feature gate for local testing should be introduced.

Summary of Changes

  • Adds a new feature enable_program_runtime_v2_and_loader_v4.
  • Adds a feature gated BuiltinPrototype for the solana_loader_v4_program.

Feature Gate Issue: #33293

Copy link
Contributor

@dmakarov dmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except it seems that program runtime v2 and loader v4 is the same thing (at least gated by the same feature flag), is that so?

@Lichtso
Copy link
Contributor Author

Lichtso commented Sep 18, 2023

Yes, the loader-v4 is the only entrypoint to the program-runtime-v2 and program-runtime-v2 is only reachable from the loader-v4. While they are not the same thing, there is still a correlation.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #33294 (ac2e997) into master (86dd18b) will increase coverage by 0.0%.
Report is 2 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33294   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         793      793           
  Lines      214812   214813    +1     
=======================================
+ Hits       176092   176095    +3     
+ Misses      38720    38718    -2     

@Lichtso Lichtso merged commit bc38ef2 into solana-labs:master Sep 19, 2023
42 checks passed
@Lichtso Lichtso deleted the feature/enable_program_runtime_v2_and_loader_v4 branch September 19, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants