Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cargo registry server's GIT index with sparse index #33666

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 11, 2023

Problem

Sparse index is more suitable for the cargo registry server.

Summary of Changes

This PR replaces the temporary GIT index with a minimal sparse index.

Client's cargo configuration

Sparse index requires the client to configure it's registry as following

my-registry-sparse = { index = "sparse+http://<registry-server-ip>:<port>/index/" }

@pgarg66 pgarg66 marked this pull request as ready for review October 11, 2023 23:11
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #33666 (5db3ba9) into master (d286c00) will increase coverage by 0.0%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #33666   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217593   217593           
=======================================
+ Hits       178091   178110   +19     
+ Misses      39502    39483   -19     

Copy link
Contributor

@Lichtso Lichtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git2 dependency can be removed, right?

@pgarg66
Copy link
Contributor Author

pgarg66 commented Oct 12, 2023

The git2 dependency can be removed, right?

Yes, that can be removed. I can do that in the next PR.

@pgarg66 pgarg66 merged commit 47540af into solana-labs:master Oct 12, 2023
31 checks passed
@pgarg66 pgarg66 deleted the sparse-index branch October 12, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants