Feature - Cooperative Program Loading #33715
Conversation
| let mut missing = Vec::new(); | ||
| let mut unloaded = Vec::new(); | ||
| let found = keys |
There was a problem hiding this comment.
Not strictly related to this PR since it was already like this, but I think this
should be a loop not a filter_map.
The iterator is filtering found, and at the same time populating missing, setting some stats,
and now also populating waiting_list. Seems arbitrary and confusing that one is done through the
iterator and the rest imperatively. As a rule of thumb, I think iterators should be for one sequence
-> one sequence transformations.
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
from
4408b4b
to
92e6a61
Compare
| if let Some(task) = loaded_programs_cache.next_cooperative_loading_task() { | ||
| task | ||
| } else { | ||
| // Waiting for some other TX batch to complete loading the programs needed by this TX batch |
There was a problem hiding this comment.
But won't this spin?
I think we should sleep when there's no work, we could use Condvar or something to sleep until the
threads that are compiling our programs signal
There was a problem hiding this comment.
Yep, it is a spin lock. Can make it ore efficient later, still working on correctness though.
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
from
92e6a61
to
1b4d9b9
Compare
Lichtso
changed the title
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
3 times, most recently
from
4183994
to
c036405
Compare
github-actions
bot
added
the
stale
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
from
c036405
to
0a6d0c7
Compare
Lichtso
removed
the
stale
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
2 times, most recently
from
de72937
to
b0e6d78
Compare
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
2 times, most recently
from
edf1dcb
to
90c139c
Compare
…lenish(). Adds LoadedPrograms::remove_program().
…ms::cooperative_loading_task_complete().
Lichtso
force-pushed
the
refactor/cooperative_porgram_loading
branch
from
90c139c
to
305dcd2
Compare
|
Closed in favor of #34407. |
Problem
Currently transaction batches race in parallel to load, verify and compile missing cache entries.
Instead they should be coordinating and split these tasks to distribute the workload across the threads and to avoid redundant work.
Summary of Changes
LoadedPrograms::replenish()andLoadedProgramsForTxBatch::replenish().LoadedProgramType::LoadingandLoadedProgram::new_loading().LoadedPrograms::get_cooperative_loading_task()andLoadedPrograms::submit_cooperative_loading_task().