RPC: Add inner instructions to simulate transaction response

[buffalojoec]

Problem

Wallets use transaction simulation to notify users about the contents of a transaction before they apply their signature. This is the primary method by which wallets, and potentially other dApps and infrastructure, detect malicious instructions.

Currently, transaction simulation offers the ability to observe the resulting account state for various account keys provided and transaction logs. However, it would provide even more enhanced security for Solana users if transaction simulation also returned the parsed inner instructions of a transaction.

Summary of Changes

The RPC change includes adding an optional parameter - innerInstructions: bool - to simulateTransaction, and adding jsonParsed inner instructions to the response type if innerInstructions is provided as true. Similar to getTransaction, if the instruction cannot be parsed with jsonParsed, it defaults to json, where the data field is base58 encoded.

This change also required the bank to return inner_instructions from its simulate_transaction method.

[CriesofCarrots]

Looking good! One attribute request, plus adding the conversion helper fn
And CI being happy, ofc

[codecov]

Codecov Report

Merging #34313 (2d5f197) into master (310c7a4) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 79.1%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #34313     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         819      820      +1     
  Lines      220889   220905     +16     
=========================================
- Hits       180845   180782     -63     
- Misses      40044    40123     +79     

[CriesofCarrots]

r+ one last nit!

[solana-grimes]

😱 New commits were pushed while the automerge label was present.