Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: Report lost_insertions metrics correctly (backport of #35191) #35199

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 14, 2024

This is an automatic backport of pull request #35191 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot assigned ryoqun Feb 14, 2024
@ryoqun
Copy link
Member

ryoqun commented Feb 15, 2024

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Feb 15, 2024

rebase

✅ Branch has been successfully rebased

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2789b8c) 81.6% compared to head (2789b8c) 81.6%.

❗ Current head 2789b8c differs from pull request most recent head cd5eaff. Consider uploading reports for the commit cd5eaff to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            v1.18   #35199   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         827      827           
  Lines      224037   224037           
=======================================
  Hits       182925   182925           
  Misses      41112    41112           

Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

@ryoqun ryoqun merged commit 6cf1bf2 into v1.18 Feb 16, 2024
35 checks passed
@ryoqun ryoqun deleted the mergify/bp/v1.18/pr-35191 branch February 16, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants