Name PubSubService tokio threads #35331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These threads use the default name (
tokio-runtime-worker
). By not having specific names, it is harder to profile the threads from this service vs. other threads that also use default nameSummary of Changes
Name the threads in this pool, and also add logs to note that the service has stopped/started. These logs will be useful if we ever need to debug the validator process hanging on teardown.