Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name PubSubService tokio threads #35331

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Feb 27, 2024

Problem

These threads use the default name (tokio-runtime-worker). By not having specific names, it is harder to profile the threads from this service vs. other threads that also use default name

Summary of Changes

Name the threads in this pool, and also add logs to note that the service has stopped/started. These logs will be useful if we ever need to debug the validator process hanging on teardown.

@steviez steviez marked this pull request as ready for review February 27, 2024 18:41
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.7%. Comparing base (8ad125d) to head (043e1af).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35331     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         834      834             
  Lines      224235   224237      +2     
=========================================
- Hits       183390   183344     -46     
- Misses      40845    40893     +48     

@steviez steviez merged commit 94698b8 into solana-labs:master Feb 27, 2024
35 checks passed
@steviez steviez deleted the pub_sub_thread_name branch February 27, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants