Add storage mining pool

[mvines]

Storage needs a mining pool to pull rewards out of.

[mvines]

@sagar-solana - this is still a WIP, I'm gonna plumb up the wallet commands in this PR too. Sharing early for FYI and any feedback though

[sagar-solana]

Yeah I think I see where you're going with this. Should be okay.
Who all owns the mining pool keypair? Where does it get deposits from?
I think we've answered those questions already but I wouldn't mind another explanation 👼

[mvines]

Who all owns the mining pool keypair?

Doesn't matter, they probably burn it actually. You can't move funds out of the mining pool once contributed.

Where does it get deposits from?

Manna from heaven.

[codecov]

Codecov Report

Merging #4364 into master will decrease coverage by 3.3%.
The diff coverage is 42.5%.

@@           Coverage Diff            @@
##           master   #4364     +/-   ##
========================================
- Coverage    79.5%   76.2%   -3.4%     
========================================
  Files         173     173             
  Lines       30391   31897   +1506     
========================================
+ Hits        24184   24306    +122     
- Misses       6207    7591   +1384

[sagar-solana]

just fyi, proof validations will not work properly right now. I'm working on getting them fixed in time. In case you need to test something, you should be able to pass in a single CheckedProof in a proof Validation and that should work.
#4377

[sagar-solana]

Dunno why that test has started failing suddenly. :/

[mvines]

Oh are you seeing it as well? I was assuming it was just this PR, and was gonna debug tomorrow

[sagar-solana]

It's likely something else. Replicators wait 50 seconds for the leader to make 16 rooted slots. Something changed recently that isn't making that happen and that test fails as a result of that.

[sagar-solana]

Minor nits. I'll defer to your judgement.

[rob-solana]

adding the wallet command tests shows next guy how to fake it ;)

[mvines]

It's likely something else. Replicators wait 50 seconds for the leader to make 16 rooted slots.
Something changed recently that isn't making that happen and that test fails as a result of that.

Oh man was stuff broken. I don't understand how some of the local cluster tests were passing before

[sagar-solana]

Oh man was stuff broken.

Shows that something needs to be fixed in our tests. That silly "start_and_exit_with_config" or whatever is a sanity test for whether or not local_clusters with a non-default config even works. It shouldn't be the only test to see some of these bugs haha

[mvines]

adding the wallet command tests shows next guy how to fake it ;)

I see these commands making it into the testnet participation doc once replicators actually work. Further adding to the already bloated test_wallet_process_command() and test_wallet_parse_command() tests seems like pretty low ROI. Was there another place you were thinking of?

[mvines]

ffs https://www.githubstatus.com/incidents/nf4gcjtcsqdb

[mvines]

@sagar-solana fyi on ac3ae02, like how did this ever work? I don't think it did.

[sagar-solana]

:O Maybe I didn't build --all when I tried it? :\

[rob-solana]

adding the wallet command tests shows next guy how to fake it ;)

I see these commands making it into the testnet participation doc once replicators actually work. Further adding to the already bloated test_wallet_process_command() and test_wallet_parse_command() tests seems like pretty low ROI. Was there another place you were thinking of?

no, that's the place

your call