Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new data-structure in shreds for partial deserialization #5915

Merged
merged 5 commits into from Sep 17, 2019

Conversation

@pgarg66
Copy link
Contributor

pgarg66 commented Sep 16, 2019

Problem

The shreds are serialized before sending over wire. To make sense of received data, the whole shreds needs to be deserialized. This is adding overhead.

Summary of Changes

Added a new data structure that can perform partial deserialization of shreds, and construct shred headers. This will reduce the overhead of serialization/deserializations.

#5704

@pgarg66 pgarg66 requested a review from sagar-solana Sep 16, 2019
core/src/shred.rs Outdated Show resolved Hide resolved
pgarg66 added 3 commits Sep 16, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #5915 into master will decrease coverage by <.1%.
The diff coverage is 84%.

@@           Coverage Diff            @@
##           master   #5915     +/-   ##
========================================
- Coverage    75.5%   75.5%   -0.1%     
========================================
  Files         236     236             
  Lines       42501   42558     +57     
========================================
+ Hits        32114   32147     +33     
- Misses      10387   10411     +24
@pgarg66 pgarg66 merged commit 7459eb1 into solana-labs:master Sep 17, 2019
10 checks passed
10 checks passed
Summary 1 rule matches and 7 potential rules
Details
buildkite/solana Build #11684 passed (1 hour, 15 minutes, 22 seconds)
Details
buildkite/solana/bench Passed (15 minutes, 3 seconds)
Details
buildkite/solana/checks Passed (1 minute, 39 seconds)
Details
buildkite/solana/coverage Passed (33 minutes, 16 seconds)
Details
buildkite/solana/pipeline-upload Passed (2 seconds)
Details
buildkite/solana/shellcheck Passed (23 seconds)
Details
buildkite/solana/stable Passed (29 minutes, 50 seconds)
Details
buildkite/solana/stable-perf Passed (14 minutes, 11 seconds)
Details
ci-gate Pull Request accepted for CI pipeline
@pgarg66 pgarg66 deleted the pgarg66:reduce-shred-serializations branch Sep 17, 2019
@pgarg66

This comment has been minimized.

Copy link
Contributor Author

pgarg66 commented Sep 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.