A new data-structure in shreds for partial deserialization #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5915 +/- ##
========================================
- Coverage 75.5% 75.5% -0.1%
========================================
Files 236 236
Lines 42501 42558 +57
========================================
+ Hits 32114 32147 +33
- Misses 10387 10411 +24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The shreds are serialized before sending over wire. To make sense of received data, the whole shreds needs to be deserialized. This is adding overhead.
Summary of Changes
Added a new data structure that can perform partial deserialization of shreds, and construct shred headers. This will reduce the overhead of serialization/deserializations.
#5704