Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rust 1.38 #6144

Closed
wants to merge 3 commits into from
Closed

Upgrade to rust 1.38 #6144

wants to merge 3 commits into from

Conversation

mvines
Copy link
Member

@mvines mvines commented Sep 27, 2019

No description provided.

@mvines
Copy link
Member Author

mvines commented Sep 27, 2019

Blocked on dealing with https://rust-lang.github.io/rust-clippy/master/index.html#try_err

I mostly just want to suppress this lint: return Err("failed".into()); is not more readable than Err("failed")?;

@garious
Copy link
Contributor

garious commented Sep 27, 2019

I read return Err("failed".into()); as "return an error". I read Err("failed")? as "that clever idiom that returns an error after hoping the compiler will apply const_prop and optimize the Err passed to try_err into return Err or otherwise add runtime overhead that may or may not be optimized away by the CPU's branch prediction".

@mvines
Copy link
Member Author

mvines commented Oct 3, 2019

586e0a6 Suppress nighly safety_doc warning
5aab286 Rebuild SVGs
a20f128 Upgrade to rust 1.38

@mvines mvines closed this Oct 3, 2019
@mvines mvines deleted the r38 branch October 3, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants