MWA 2.0 Library RPC Changes #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funkatronics
changed the title
creativedrewy
approved these changes
Oct 6, 2023
|
gonna merge, and fork my unit tests to a new PR so @creativedrewy can start playing around with in the sample apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the RPC changes from the MWA 2.0 spec, excluding the Sign in With Solana feature.
This PR begins to address issue #44 (support multiple authorized accounts), but does not completely flesh this out. The PR became way too big and I was struggling to get the SQL stuff working with multiple accounts per authorization in the auth repository. I have forked these changes and will open a separate PR. The new account metadata fields (
chainsandfeatures) are not fully supported in this PR for the same reason (the scenario processes these params, but they are not stored in the auth repository).Apps (fakewallet/dapp) are unchanged because:
TODO: currently adding unit tests