Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate signTransactions in libs #581

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Deprecate signTransactions in libs #581

merged 1 commit into from
Oct 20, 2023

Conversation

Funkatronics
Copy link
Contributor

No description provided.

@Funkatronics
Copy link
Contributor Author

@creativedrewy this might break the example ktx app

creativedrewy
creativedrewy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@creativedrewy creativedrewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think KTX stuff should be good!

@Funkatronics
Copy link
Contributor Author

ty drewy. gonna merge this pr, tho we still need to think about the implications of deprecating signTransaction and backwards compat.

@Funkatronics Funkatronics changed the title [WIP] Deprecate signTransactions in libs Deprecate signTransactions in libs Oct 20, 2023
@Funkatronics Funkatronics merged commit b24dec1 into main Oct 20, 2023
6 checks passed
@Funkatronics Funkatronics deleted the deprecate-sign-only-impl branch October 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creativedrewy creativedrewy creativedrewy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Funkatronics @creativedrewy