Fix: fakedapp legacy cluster param #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funkatronics
commented
Mar 14, 2024
| identity.uri, identity.iconRelativeUri, identity.name, chain, | ||
| null, null, null, signInPayload | ||
| ).get()!! | ||
| if (protocolVersion == ProtocolVersion.V1) { |
There was a problem hiding this comment.
clientlib-kt and the js libs handle this internally, but fakedapp needs to do it manually.
Michaelsulistio
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the kt and react/web libraries handle backwards compatibility automatically, while the core java SDK does not (significant refactor was needed to make the java client session aware so we opted to handle it in the wrapper libs that most use). This PR fixes an issue with fakedapp not handling the backwards compat with legacy wallets (
chainvsclusterparam).