Allow pasting into fields in test UI #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% about this fix, I might be missing some nuance about how search bar items work
But the reason pasting was not working is because
item.value ||= clipboardText
was never updating, becauseitem.value
was truthy:This PR changes it to always replace
item.value
with the pasted textAn alternative fix would be to remove the{current: true}
from the Custom item, so thatitem.value
is just whatever that field contains, but I'm not sure what that represents/would do.Actually I guess that wouldn't work because then you couldn't paste unless the field was empty. I'm not sure if there are circumstances where we shouldn't change
item.value
on paste though.Fixes #188