Add extensions/cap_realhost #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ideal would be possible if the outbound_msgbuf hook included the target information. Otherwise, seems fine to me. |
|
As it stands the hook is called just once for something like a channel message, even though it goes out to lots of users, and the send machinery takes care of formatting different concrete lines for people with distinct capability sets. I'd like to keep that, so we probably need to teach the sending stuff about privs. |
edk0
force-pushed
the
edk/cap-realhost
branch
3 times, most recently
from
68ebe7a
to
fc11487
Compare
edk0
force-pushed
the
edk/cap-realhost
branch
from
fc11487
to
82f3a65
Compare
|
Sigyn approves |
jesopo
previously approved these changes
Oct 22, 2020
jesopo
previously approved these changes
Oct 22, 2020
glguy
reviewed
Oct 24, 2020
If they can see it it's already in the message source
edk0
force-pushed
the
edk/cap-realhost
branch
from
7480dfe
to
d611aeb
Compare
glguy
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
solanum.chat/realhostclient capability, which sends thesolanum.chat/realhostandsolanum.chat/ipvendor tags on user-sourced messages as appropriate.Hidden IPs and hostnames are sent to
auspex:hostnameopers. For consistency, if a remote oper wouldn't see an IP (because it's behind an IP spoof and not propagated), it's not shown to local opers either. Internally the oper version of the tag is implemented with an invisible cap named?oper_realhost.originally: I'm not terribly happy with the state of this, but improving it depends on having tags that are gated by privs, which may itself depend on changing how privsets work.
Ideally the cap would be available to all users, but just wouldn't reveal hidden information to the unprivileged.