API for automatically splitting long messages in places where spec allows/requires it #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
from
d19f95e
to
2bc579f
Compare
edk0
suggested changes
Nov 7, 2020
There was a problem hiding this comment.
The missing (void) is the only serious problem here, and it's easy to address :)
One thing that crossed my mind and doesn't really fit anywhere specific in the diff is that it'd be pretty easy to keep the prefix in the same buffer we use to build items, but I don't see any great benefit beside the warm fuzzy feeling of saving a BUFSIZE.
edk0
reviewed
Nov 8, 2020
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
from
6a4faa9
to
d34ab36
Compare
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
2 times, most recently
from
7f6f2e9
to
29f72a3
Compare
edk0
reviewed
Nov 9, 2020
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
from
29f72a3
to
4b958a2
Compare
edk0
suggested changes
Nov 11, 2020
There was a problem hiding this comment.
Modulo suggestions I think this is in a pretty good place now.
I think it might be worth raising, since this will be the last good opportunity to filter-branch, the question of whether we could bikeshed the names down a bit. sendto_one_multiline_remote_extra_space doesn't exactly roll off the tongue.
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
2 times, most recently
from
66e06fb
to
20ed37d
Compare
Allows simplifying multiline wrapping for multiple usages, like CAP LS/LIST, NAMES, and WHOIS channel listing
dwfreed
force-pushed
the
dwfreed/sendto-one-multiline
branch
from
20ed37d
to
34f3df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will greatly simplify and deduplicate code in various places, like CAP LS/LIST, NAMES, and WHOIS channel lists.
Fixes #16