Reference forecast limit #727
Conversation
|
|
||
| def _limit_persistence_run_time(data_start, max_run_time, forecast): | ||
| """Get a the last run time that would result in the | ||
| forecast producing points as limited by PERS_PT_LIMIT. |
There was a problem hiding this comment.
Here it's PERS_PT_LIMIT, but PERSISTENCE_PT_LIMIT in code and other documentation. I might spell out POINT too.
Don't we prefix some Arbiter env vars with SFA? Not sure how consistent we might be about that so don't know if this is really an issue.
There was a problem hiding this comment.
Replace doc string with:
Get the last run time.
Last run time is either max_run_time or the time that limits the forecast length to value set by SFA_PERISTENCE_POINT_LIMIT environment variable or DEFAULT_PERSISTENCE_POINT_LIMIT.
|
|
||
| pts_per_run = forecast.run_length / forecast.interval_length | ||
|
|
||
| max_runs = fx_pt_limit / pts_per_run |
There was a problem hiding this comment.
Do we need to floor this? max_runs suggests an integer.
| generated to the the limit provided by the PERISTENCE_PT_LIMIT env var | ||
| or DEFAULT_PERS_PT_LIMIT. | ||
| """ | ||
| fx_pt_limit = float(os.getenv('PERSISTENCE_PT_LIMIT', DEFAULT_PERS_PT_LIMIT)) |
solarforecastarbiter/cli.py
Outdated
| Timeseries creatd are further limited by the maximum number of points | ||
| generated for any one forecast. The default limit is 136800 points, |
There was a problem hiding this comment.
Unclear. "Each forecast is further limited to a maximum number of points."?
| forecast_hr_begin, start, limit, expected, monkeypatch | ||
| ): | ||
| max_run_time = pd.Timestamp('2021-01-10T00:00Z') | ||
| monkeypatch.setenv("PERS_PT_LIMIT", str(limit)) |
There was a problem hiding this comment.
Does this actually work? Doesn't match the env var in the function
Co-authored-by: Will Holmgren <william.holmgren@gmail.com>
|
|
||
| def _limit_persistence_run_time(data_start, max_run_time, forecast): | ||
| """Get a the last run time that would result in the | ||
| forecast producing points as limited by PERS_PT_LIMIT. |
There was a problem hiding this comment.
Replace doc string with:
Get the last run time.
Last run time is either max_run_time or the time that limits the forecast length to value set by SFA_PERISTENCE_POINT_LIMIT environment variable or DEFAULT_PERSISTENCE_POINT_LIMIT.
Co-authored-by: Will Holmgren <william.holmgren@gmail.com>
docs/source/api.rstfor API changes.docs/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).