Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probabilistic ref persistence generation fnc #490

Merged
merged 11 commits into from
Jun 26, 2020

Conversation

alorenzo175
Copy link
Contributor

@alorenzo175 alorenzo175 commented Jun 24, 2020

  • Closes #xxxx .
  • I am familiar with the contributing guidelines.
  • Tests added.
  • Updates entries to docs/source/api.rst for API changes.
  • Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Only adds a single reference probabilistic persistence forecast which is probably sufficient for 1.0 and avoids a whole bunch of new series. Also consolidates the observation get and forecast post code to avoid a bunch of network roundtrips that have been causing delays on the current reference sets.

@alorenzo175 alorenzo175 added enhancement New feature or request referencefx Issue pertains to reference forecasts labels Jun 24, 2020
@alorenzo175 alorenzo175 added this to the 1.0 release candidate milestone Jun 24, 2020
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docs and comments...

@alorenzo175 alorenzo175 merged commit dd0525a into SolarArbiter:master Jun 26, 2020
@alorenzo175 alorenzo175 deleted the probper branch June 26, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request referencefx Issue pertains to reference forecasts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants