Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime is not set to UTC when using Extract #618

Closed
jeroenherczeg opened this issue Aug 8, 2018 · 5 comments
Closed

DateTime is not set to UTC when using Extract #618

jeroenherczeg opened this issue Aug 8, 2018 · 5 comments

Comments

@jeroenherczeg
Copy link
Contributor

When using the update QueryType, it will change the timezone to UTC.
When using the extract QueryType, it will keep not change it to UTC.
@jeroenherczeg jeroenherczeg mentioned this issue Aug 8, 2018
Merged
mkalkbrenner pushed a commit that referenced this issue Aug 9, 2018
@jeroenherczeg
Fix for #618 DateTime is not set to UTC when using Extract (#619)
4dfd71f 
* Test for issue 618 - DateTime not set to UTC

* Fix issue 618 - DateTime not set to UTC
@jeroenherczeg
Copy link
Contributor Author

jeroenherczeg commented Aug 14, 2018 •
edited

Would it be possible to get this fix in v3?
Our current PHP version is 5.5, so we are not able to use v4 just yet.

@mkalkbrenner
Copy link
Member

mkalkbrenner commented Aug 14, 2018 •
edited

Sure, if the v3 maintainer @thePanz agrees and if you file a new PR for that, or at least a new issue.

@jeroenherczeg
Copy link
Contributor Author

I will create a new PR, which branch should it be based of?

@mkalkbrenner
Copy link
Member

3.x
https://github.com/solariumphp/solarium/tree/3.x

jeroenherczeg added a commit to jeroenherczeg/solarium that referenced this issue Aug 14, 2018
@jeroenherczeg
Fix for solariumphp#618 DateTime is not set to UTC when using Extract
396e1fd
@thePanz
Copy link
Member

thePanz commented Aug 15, 2018

@jeroenherczeg it's fine for me! :)
Your code changes look good to me, please link here your PR and I'll merge it

@jeroenherczeg jeroenherczeg mentioned this issue Aug 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thePanz @mkalkbrenner @jeroenherczeg